8000 Make sure 'changing' and 'changed' are set together by lumimies · Pull Request #493 · js-data/js-data · GitHub
[go: up one dir, main page]

Skip to content

Make sure 'changing' and 'changed' are set together #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

lumimies
Copy link
Contributor
@lumimies lumimies commented Feb 7, 2018

Schema expects this invariant, and gets to an inconsistent state when saving.

Fixes #416 (I believe)

  • - npm test succeeds
  • - Code coverage does not decrease (if any source code was changed)

Zohar Kelrich added 2 commits February 8, 2018 12:07
Schema expects this invariant, and gets to an inconsistent state when saving.
@codecov
Copy link
codecov bot commented Feb 8, 2018

Codecov Report

Merging #493 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   95.83%   95.83%   +<.01%     
==========================================
  Files          21       21              
  Lines        2523     2524       +1     
==========================================
+ Hits         2418     2419       +1     
  Misses        105      105
Impacted Files Coverage Δ
src/Record.js 99.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d102a...d04d481. Read the comment docs.

Copy link
Member
@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jmdobry jmdobry merged commit ba69793 into js-data:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0