8000 check that inverseDef exists before attempting to setup Inverse for belongsTo by pik · Pull Request #382 · js-data/js-data · GitHub
[go: up one dir, main page]
Skip to content

check that inverseDef exists before attempting to setup Inverse for belongsTo #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2016
Merged

check that inverseDef exists before attempting to setup Inverse for belongsTo #382

merged 3 commits into from
Aug 3, 2016

Conversation

pik
Copy link
Contributor
@pik pik commented Aug 2, 2016

The only real change in this PR is the addition of guard conditions - but this also extracts removeInverseRelation / setupInverseRelation to their own functions. Currently the descriptor set is a very fat method and difficult to test (as well as to read). As a side effect, safeSetLink and safeSetProp got moved to utils.

@jmdobry jmdobry mentioned this pull request Aug 3, 2016
Closed
@jmdobry jmdobry merged commit 1366b46 into js-data:master Aug 3, 2016
@jmdobry jmdobry modified the milestone: 3.0.0 Release Candidate Aug 3, 2016
@jmdobry jmdobry mentioned this pull request Aug 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug done
Projects
None yet
Milestone
3.0.0 Release Candidate
Development

Successfully merging this pull request may close these issues.
2 participants
@pik @jmdobry
0