Allow binding only portions of core classes#8903
Draft
headius wants to merge 2 commits intojruby:masterfrom
Draft
Allow binding only portions of core classes#8903headius wants to merge 2 commits intojruby:masterfrom
headius wants to merge 2 commits intojruby:masterfrom
Conversation
Interface static method invocations must be emitted with the new InterfaceMethodref descriptor, which we were not doing for the generated invokers. This fixes that.
This moves IO-related Kernel methods to a separate interface which can be enabled or disabled independently of the rest of Kernel. This relates to recent discussions about making JRuby safely embeddable with only specific classes and features loaded. See other work in jruby#8893
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment to modularize the binding of core class methods on classes which have many different sets of behaviors. Initially, the work is based on modularizing Kernel to allow optionally binding methods that access things like IO.
This relates to recent discussions about making JRuby smaller and more secure for embedded use cases that may want to be able to disable things like IO and Thread. We need to be able to disable related features in other classes and modules like Kernel for that to be fully realized.
See related work in #8893.