Localization: Rename message_hi.js to messages_hindi.js #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with other i18n file names (which are all written in plural).
|
I think we'll have to hold off on that as it may break build systems that rely on the old file name. |
|
@bytestream Not sure if this makes much of a difference, but FWIW no official releases currently use the file this PR is seeking to rename. The latest release of the jQuery validation plugin (1.9.5) was rolled out in July 2022 and doesn't include any Hindi translations at all. The In any case, feel free to close this PR if you still think keeping it "as-is" would be a better bet :). |
|
Thanks for the clarification @EricDunsworth |
bytestream
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with other i18n file names (which are all written in plural).