ABARoutingNumber: Add ABA Routing Number Validation #2216
Conversation
|
Thanks for your contribution! I'll triage and take a look at it as soon as possible! |
There was a problem hiding this comment.
Thanks a lot for your contribution. Overall, the PR looks good to. Only a minor change and we are good to go.
I would like also if you could add the test file to test/index.html after these two lines:
jquery-validation/test/index.html
Lines 18 to 19 in 3a7e593
src/additional/ABARoutingNumber.js
Outdated
| * systems. A very common use case would be to validate a form for | ||
| * an ACH bill payment. | ||
| */ | ||
| $.validator.addMethod( "ABARoutingNumber", function( value ) { |
There was a problem hiding this comment.
Can you make the first 3 letters lowercase, so it maintain consistence with the other additional methods?
test/additional/ABARoutingNumber.js
Outdated
| @@ -0,0 +1,23 @@ | |||
| QUnit.test( "ABARoutingNumber", function( assert ) { | |||
| var method = methodTest( "ABARoutingNumber" ); | |||
There was a problem hiding this comment.
This will need also to be changed after updating the name.
|
The filenames should also use lower letters. |
|
Good catch @staabm. @coryasilva could you please rename the source and test files to be the same as the method name? After that, we are good to go. Thanks! |
|
lol, damn windows box. The company finally gave me a macbook, give me a couple more days to migrate my dev environment and I will make sure the file renames stick. |
|
Okay I just renamed the files in github. I hope that worked. |
Description
This is used in the United States to process payments, deposits, or transfers using the Automated Clearing House (ACH) or Fedwire systems. A very common use case would be to validate a form for an ACH bill payment.
https://en.wikipedia.org/wiki/ABA_routing_transit_number