8000 Core: Provide a package.json exports setup inspired by jQuery Core by mgol · Pull Request #566 · jquery/jquery-migrate · GitHub
[go: up one dir, main page]
Skip to content

Core: Provide a package.json exports setup inspired by jQuery Core #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Core: Provide a package.json exports setup inspired by jQuery Core #566

merged 1 commit into from
Apr 14, 2025

Conversation

mgol
Copy link
Member
@mgol mgol commented Mar 31, 2025 •
edited
Loading

The Migrate setup is simpler than Core as it doesn't have the slim or factory versions, but the core ideas are similar.

Fixes gh-524
Ref jquery/jquery#5255
Ref jquery/jquery#5429

@mgol mgol added this to the 4.0.0 milestone Mar 31, 2025
@mgol mgol self-assigned this Mar 31, 2025
@mgol mgol removed the Needs review label Mar 31, 2025
@mgol mgol mentioned this pull request Mar 31, 2025
Closed
@mgol
Copy link
Member Author
mgol commented Mar 31, 2025

I pushed it to main on my fork and the BrowserStack run was green: https://github.com/mgol/jquery-migrate/actions/runs/14175885687

@mgol mgol requested a review from timmywil March 31, 2025 16:29
@mgol
Core: Provide a package.json exports setup inspired by jQuery Core
f87fbab 
The Migrate setup is simpler than Core as it doesn't have the slim or factory
versions, but the core ideas are similar.

Fixes jquerygh-524
Ref jquery/jquery#5255
Ref jquery/jquery#5429
timmywil
timmywil approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member
@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Apr 4, 2025
@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Apr 14, 2025
@mgol mgol merged commit 94ab4c5 into jquery:main Apr 14, 2025
13 checks passed
@mgol mgol deleted the exports branch April 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels
4.x-only
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Provide exports setup similar to jQuery 4.0.0
2 participants
@mgol @timmywil
0