8000 Tests: Make `:has` selector tests not vulnerable to unrelated failures by mgol · Pull Request #5497 · jquery/jquery · GitHub
[go: up one dir, main page]
Skip to content
/ jquery Public

Tests: Make :has selector tests not vulnerable to unrelated failures #5497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

Tests: Make :has selector tests not vulnerable to unrelated failures #5497

merged 1 commit into from
May 29, 2024

Conversation

mgol
Copy link
Member
@mgol mgol commented May 29, 2024 •
edited
Loading

Summary

Use assert.selectInFixture consistently in :has tests. Previously, any test failure that happened before this test run made it fail due to an additional paragraph with id qunit-testresult injected by QUnit.

Checklist

@mgol
Tests: Make :has selector tests not vulnerable to unrelated failures
7f6a237 
Use `assert.selectInFixture` consistently in `:has` tests. Previously, any test
failure that happened before this test run made it fail due to an additional
paragraph with id `qunit-testresult` injected by QUnit.
@mgol mgol self-assigned this May 29, 2024
mgol added a commit to mgol/jquery that referenced this pull request May 29, 2024
@mgol
Tests: Align :has selector tests with 3.x-stable
a4f48e7 
Consistently use `assert.selectInFixture` instead of prepending the selector
with `#qunit-fixture ` manually.

Ref jquerygh-5497
@mgol mgol mentioned this pull request May 29, 2024
Merged
@mgol
Copy link
Member Author
mgol commented May 29, 2024

Disregard the only test failure - it's caused by #5489 for which I already have PRs open.

@mgol mgol merged commit b6f53de into jquery:3.x-stable May 29, 2024
10 of 11 checks passed
@mgol mgol deleted the 3.x-has-tests-fragility branch May 29, 2024 16:32
@mgol mgol added this to the 3.7.2 milestone May 29, 2024
@mgol mgol removed the Needs review label May 29, 2024
mgol added a commit that referenced this pull request May 29, 2024
@mgol
Tests: Align :has selector tests with 3.x-stable
< 6D19 batch-deferred-content class="d-inline-block" data-url="/jquery/jquery/commits/checks-statuses-rollups">
f2d9fde 
Consistently use `assert.selectInFixture` instead of prepending the selector
with `#qunit-fixture ` manually.

Closes gh-5498
Ref gh-5497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels
Tests
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @timmywil
0