CSS:Tests: Fix tests & support tests under CSS Zoom (3.x version) #5496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 29, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Also, skip the width setter under zoom test in Firefox 126 completely - that version has CSS zoom affecting `offsetWidth` values. This has been fixed in Firefox 127 so it's not worth working around it. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes jquerygh-5489 Closes jquerygh-5496 Ref jquerygh-5495
7fb1e19 to
f163b3d
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 29, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Add a test for support tests resolving the same under CSS zoom & without one. Fixes jquerygh-5489 Closes jquerygh-5495 Ref jquerygh-5496
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 29, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes jquerygh-5489 Closes jquerygh-5495 Ref jquerygh-5496
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 29, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes jquerygh-5489 Closes jquerygh-5495 Ref jquerygh-5496
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 29, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Also, skip the width setter under zoom test in Firefox 126 completely - that version has CSS zoom affecting `offsetWidth` values. This has been fixed in Firefox 127 so it's not worth working around it. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes jquerygh-5489 Closes jquerygh-5496 Ref jquerygh-5495
f163b3d to
5b11c77
Compare
|
Size diffs: |
timmywil
approved these changes
May 29, 2024
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 29, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes jquerygh-5489 Closes jquerygh-5495 Ref jquerygh-5496
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Also, skip the width setter under zoom test in Firefox 126 completely - that version has CSS zoom affecting `offsetWidth` values. This has been fixed in Firefox 127 so it's not worth working around it. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes jquerygh-5489 Closes jquerygh-5496 Ref jquerygh-5495
5b11c77 to
7c935e2
Compare
mgol
added a commit
that referenced
this pull request
Jun 3, 2024
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes gh-5489 Closes gh-5495 Ref gh-5496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Firefox 126+ implements CSS zoom in a way it affects width computed style
very slightly (
100.008pxinstead of100px); accept that difference.Also, skip the width setter under zoom test in Firefox 126 completely - that
version has CSS zoom affecting
offsetWidthvalues. This has been fixed inFirefox 127 so it's not worth working around it.
Add a test for support tests resolving the same under CSS zoom & without one.
That test uncovered Chrome failing the
reliableTrDimensionssupport testunder zoom; the test has been fixed.
Fixes gh-5489
Closes gh-5496
Ref gh-5495
4.xversion: gh-5495Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com