8000 Tests: reuse browser workers in BrowserStack tests by timmywil · Pull Request #5428 · jquery/jquery · GitHub
[go: up one dir, main page]
Skip to content

Tests: reuse browser workers in BrowserStack tests #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2024
Merged

Tests: reuse browser workers in BrowserStack tests #5428

merged 6 commits into from
Mar 5, 2024

Conversation

timmywil
Copy link
Member
@timmywil timmywil commented Mar 2, 2024 •
edited
Loading

Summary

I suggest reviewing #5427 first. Any more changes made there that might apply to main I will add here as well.

  • reuse BrowserStack workers.
  • add support for "latest" and "latest-1" in browser version filters
  • add support for specifying non-final browser versions, such as beta versions
  • more accurate eslint for files in test/runner
  • switched --no-isolate command flag to --isolate. Now that browser instances are shared, it made more sense to me to default to no isolation unless specified. This turned out to be cleaner because the only place we isolate is in browserstack.yml.
  • fixed an issue with retries where it wasn't always waiting for the retried test run

Rather than spinning up a separate browser instance for each module, we send back the next test's URL when a module completes, if there is one. Then listeners.js sets window.location. At first, I tried BrowserStack's change url API, but it was slower and incredibly error-prone.

Sample BrowserStack run: https://github.com/timmywil/jquery/actions/runs/8123504592

Testing time has gone from 15-30min to 5min!

Checklist

@timmywil
Tests: reuse browser workers in BrowserStack tests
9d31db3 
- add support for "latest" and "latest-1" in browser version filters
- add support for specifying non-final browser versions, such as beta
  versions
@timmywil timmywil 8000 added the Tests label Mar 2, 2024
@timmywil timmywil added this to the 4.0.0 milestone Mar 2, 2024
@timmywil timmywil requested a review from mgol March 2, 2024 14:57
@timmywil timmywil self-assigned this Mar 3, 2024
@timmywil timmywil mentioned this pull request Mar 5, 2024
Merged
2 tasks
mgol
mgol reviewed Mar 5, 2024
View reviewed changes
Copy link
Member
@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cursore review of this proved useful in the end. 😉

@timmywil timmywil merged commit 95a4c94 into jquery:main Mar 5, 2024
@timmywil timmywil deleted the migrate-test branch March 5, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

Assignees

@timmywil timmywil

Labels
Tests
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timmywil @mgol
0