8000 Tests: Workaround failures in recent XSS tests in iOS 8 - 12 by mgol · Pull Request #4694 · jquery/jquery · GitHub
[go: up one dir, main page]
Skip to content
/ jquery Public

Tests: Workaround failures in recent XSS tests in iOS 8 - 12 #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Tests: Workaround failures in recent XSS tests in iOS 8 - 12 #4694

merged 1 commit into from
Apr 30, 2020

Conversation

mgol
Copy link
Member
@mgol mgol commented Apr 29, 2020

Summary

iOS 8-12 parses <noembed> tags differently, executing this code. This is no
different to native behavior on that OS, though, so just accept it.

Ref gh-4685

Checklist

@mgol
Tests: Workaround failures in recent XSS tests in iOS 8 - 12
03d34a5 
iOS 8-12 parses `<noembed>` tags differently, executing this code. This is no
different to native behavior on that OS, though, so just accept it.

Ref jquerygh-4685
@mgol mgol added Needs review Tests Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Apr 29, 2020
@mgol mgol added this to the 3.5.1 milestone Apr 29, 2020
@mgol mgol self-assigned this Apr 29, 2020
@mgol mgol mentioned this pull request Apr 29, 2020
Merged
3 tasks
@mgol mgol requested review from gibson042 and timmywil April 29, 2020 15:08
@mgol
Copy link
Member Author
mgol commented Apr 29, 2020

Test runs showing the failure:
http://swarm.jquery.org/job/9718 (master)
http://swarm.jquery.org/job/9719 (3.x-stable)

@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Apr 30, 2020
@mgol mgol merged commit 11066a9 into jquery:master Apr 30, 2020
@mgol mgol deleted the manip-security-tests-ios-fix branch April 30, 2020 19:25
mgol added a commit that referenced this pull request Apr 30, 2020
@mgol
Tests: Workaround failures in recent XSS tests in iOS 8 - 12
ea2d0d5 
iOS 8-12 parses `<noembed>` tags differently, executing this code. This is no
different to native behavior on that OS, though, so just accept it.

Ref gh-4685
Closes gh-4694

(cherry picked from commit 11066a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 approved these changes

@timmywil timmywil Awaiting requested review from timmywil

Assignees

@mgol mgol

Labels
Tests
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @gibson042
0