8000 Manipulation: Skip the select wrapper for <option> outside of IE 9 by mgol · Pull Request #4647 · jquery/jquery · GitHub
[go: up one dir, main page]
Skip to content

Manipulation: Skip the select wrapper for <option> outside of IE 9 #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you ag 8000 ree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Manipulation: Skip the select wrapper for <option> outside of IE 9 #4647

merged 1 commit into from
Mar 30, 2020

Conversation

mgol
Copy link
Member
@mgol mgol commented Mar 25, 2020 •
edited
Loading

Summary

Skip the select wrapper for outside of IE 9.

+29 +20 bytes.

This is a security fix for CVE-2020-11023.

Checklist

@mgol mgol added this to the 3.5.0 milestone Mar 25, 2020
@mgol mgol self-assigned this Mar 25, 2020
@mgol mgol force-pushed the 3.x-wrapMap-option branch from fb425bb to 25c0a6e Compare March 25, 2020 15:35
@mgol
Copy link
Member Author
mgol commented Mar 25, 2020

Reduced to +20 bytes.

@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Mar 26, 2020
@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Mar 30, 2020
@mgol mgol merged commit 966a709 into jquery:3.x-stable Mar 30, 2020
@mgol mgol deleted the 3.x-wrapMap-option branch March 30, 2020 18:15
@mgol mgol mentioned this pull request Apr 23, 2020
Merged
3 tasks
mgol added a commit that referenced this pull request Apr 29, 2020
@mgol
8000 Tests: Add tests for recently fixed manipulation XSS issues
dc06d68 
Closes gh-4685
Ref gh-4642
Ref gh-4647
mgol added a commit that referenced this pull request Apr 29, 2020
@mgol
Tests: Add tests for recently fixed manipulation XSS issues
58a8e87 
Closes gh-4685
Ref gh-4642
Ref gh-4647

(cherry picked from commit dc06d68)
@mgol mgol mentioned this pull request May 2, 2020
Closed
serg-cymbaluk added a commit to serg-cymbaluk/freeipa that referenced this pull request Sep 21, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
a74d68a 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
@serg-cymbaluk serg-cymbaluk mentioned this pull request Sep 21, 2020
Closed
serg-cymbaluk added a commit to serg-cymbaluk/freeipa that referenced this pull request Sep 23, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
8dd1a70 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
serg-cymbaluk added a commit to serg-cymbaluk/freeipa that referenced this pull request Sep 23, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
ca6e589 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
serg-cymbaluk added a commit to serg-cymbaluk/freeipa that referenced this pull request Sep 24, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
02a9bd0 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
serg-cymbaluk added a commit to serg-cymbaluk/freeipa that referenced this pull request Sep 24, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
1fd411a 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
freeipa-pr-ci pushed a commit to freeipa-pr-ci/freeipa that referenced this pull request Sep 24, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
090a222 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
serg-cymbaluk added a commit to serg-cymbaluk/freeipa that referenced this pull request Oct 7, 2020
@serg-cymbaluk
WebUI: Fix jQuery DOM manipulation issues
1e249fd 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
@serg-cymbaluk serg-cymbaluk mentioned this pull request Oct 7, 2020
Closed
abbra pushed a commit to freeipa/freeipa that referenced this pull request Oct 9, 2020
@serg-cymbaluk @flo-renaud
WebUI: Fix jQuery DOM manipulation issues
a7da459 
The commit includes the following jQuery patches:
- Manipulation: Make jQuery.htmlPrefilter an identity function
  (jquery/jquery#4642)
- Manipulation: Skip
8000
 the select wrapper for <option> outside of IE 9
  (jquery/jquery#4647)

In addition there is included a script that helps to patch and build
the new version of jQuery:

  $ install/ui/util/make-jquery.js 3.4.1

Ticket: https://pagure.io/freeipa/issue/8507

Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
tamcy pushed a commit to tamcy/jquery that referenced this pull request Mar 17, 2022
@mgol @tamcy
Manipulation: Skip the select wrapper for <option> outside of IE 9
5f203e9 
Closes jquerygh-4647
# Conflicts:
#	src/manipulation/wrapMap.js
#	test/unit/support.js
roytoo added a commit to roytoo/jquery that referenced this pull request May 29, 2022
@roytoo
Manipulation: Skip the select wrapper for <option> outside of IE 9
c96e7e1 
Closes jquerygh-4647
roytoo pushed a commit to roytoo/jquery that referenced this pull request Jun 20, 2022
@royadamsrp
Back port of 3.5.0 fixes to CVE-2020-11022/CVE-2020-11023
97c9343 
jquery#4647
jquery@966a709
This was referenced Jul 28, 2022
Open
Open
@cx-alexey-kononov cx-alexey-kononov mentioned this pull request Aug 4, 2022
Closed
msablic added a commit to msablic/jquery that referenced this pull request Sep 29, 2022
@msablic
Manipulation: Skip the select wrapper for <option> outside of IE9
004b278 
Closes jquerygh-4647
This was referenced Aug 1, 2022
Closed
Closed
@cxflowtestuser cxflowtestuser mentioned this pull request Feb 10, 2022
Closed
This was referenced Mar 3, 2023
Closed
Closed
@AASMACMX AASMACMX mentioned this pull request Feb 26, 2023
Open
This was referenced Mar 15, 2023
Closed
Closed
This was referenced Apr 26, 2023
Open
Open
This was referenced Mar 15, 2023
Closed
Closed
This was referenced Jul 10, 2023
Open
Open
@cx-alexey-kononov cx-alexey-kononov mentioned this pull request Nov 13, 2022
Closed
rickypowell pushed a commit to draios/jquery that referenced this pull request Mar 12, 2024
@mgol @rickypowell
Manipulation: Skip the select wrapper for <option> outside of IE 9
736bbfc 
Closes jquerygh-4647
@cx-alexey-kononov cx-alexey-kononov mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels
Manipulation
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mgol @timmywil
0