fixing memory leaks and other issues reported by Coverity Prevent. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
event is allocated memory which is not freed if malloc for buffer fails.
free port->name in function MIDIPortCreate before returning NULL if port->ports is NULL.
Fix for Out-of-bounds write error(Overrunning array)
fix for integer overflow issue.
fix for integer overflow issue.
Initialize sockaddr_in variable to clear sin_zero field to avoid undifined behavior. Socket system call's return is validated. Fix of memory allocated ( for size 52 bytes) in case of error scenario not deleted.
Initialize sockaddr_in variable to clear sin_zero field to avoid undifined behavior. Socket system call's return is validated before the call of bind.
|
This looks very good. Thank you a lot, Vishal! |
jpommerening
added a commit
that referenced
this pull request
Jan 3, 2014
fixing memory leaks and other issues reported by Coverity Prevent. * out-of-bounds write errors * unchecked socket() errors * memset() on sockaddr_in * integer overflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applemidi.c
1 Initialize sockaddr_in variable to clear sin_zero field to avoid undifined behavior.
2 Socket system call's return is validated before the call of bind.
osc.c
1 Initialize sockaddr_in variable to clear sin_zero field to avoid undifined behavior.
1 Socket system call's return is validated.
1 Fix of memory allocated ( for size 52 bytes) in case of error scenario not deleted.
clock.c
1 fix for integer overflow issue.
device.c
1 Fix for Out-of-bounds write error(Overrunning array)
event.c
1 Fix of memory allocated ( for size 32 bytes) in case of error scenario not deleted.
port.c
2 Fix of dymaic sized allocated memory and for 32 bytes memory not deleted in error scenario.