-
Notifications
You must be signed in to change notification settings - Fork 99
Add escape filter #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add escape filter #144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 87.26% 87.29% +0.02%
==========================================
Files 64 64
Lines 7219 7226 +7
==========================================
+ Hits 6300 6308 +8
+ Misses 919 918 -1
Continue to review full report at Codecov.
|
Thanks for contributing! What the exact problem with test for quotes? |
I think that I solved that, I had to escape both the quotes and the backslash |
Another approach is to use raw-string literals: But your current solution is ok as well. |
@morenol , sorry, I made a mistake when was resolving conflicts of your PR and new master. I missed the |
Done! |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@morenol I can merge your PR now or wait till the October, 1st. What would your prefer? |
Merge, I hope to do more of them in October! |
I noticed that I haven't edited the readme, I'm going to do that, Is it ok? |
It's ok. I'm preparing the big PR with preparation to the version 1.0.0 release, so I'll edit the readme in any case. |
Solves #140
Still work in progress, not sure how to test the quotes (‘, ”).