warn for unicode escapes that are too long #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\u with more than 4 or \U with more than 6 hex digits previously were silently split into the legal 4 or 6 unicode escape, followed by normal character matches. Usually these occurrences are errors, but there may be specifications that rely on this behaviour, so instead of an error we produce a warning that can be suppressed. Fixes #183
After previous refactorings unicodeProperties can be null in LexScan.flex. Initialise to default if no unicode directive has been encountered yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\uwith more than 4 or\Uwith more than 6 hex digits previously were silently split into the legal 4 or 6 unicode escape, followed by normal character matches. Usually these occurrences are errors, but there may be specifications that rely on this behaviour, so instead of an error we produce a warning that can be suppressed.Fixes #183