8000 chore: convert to TS by SimenB · Pull Request #305 · jest-community/eslint-plugin-jest · GitHub
[go: up one dir, main page]
Skip to content

chore: convert to TS #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 22, 2019
Merged

chore: convert to TS #305

merged 21 commits into from
Jul 22, 2019

Conversation

SimenB
Copy link
Member
@SimenB SimenB commented Jul 17, 2019 •
edited
Loading

Take 2 of the TS migration.

Needs to wait for typescript-eslint/typescript-eslint#712 to avoid peer dep warning when installing this, but I think this now works beyond that 🙂

~^ is released as canary. We should either wait for a stable or their next major, then we can merge this 🤞 ~

^ Out as 1.13, will merge this

/cc @jeysal

@SimenB SimenB mentioned this pull request Jul 17, 2019
Closed
35 tasks
SimenB
SimenB commented Jul 17, 2019
View reviewed changes
@SimenB
Copy link
Member Author
SimenB commented Jul 20, 2019 •
edited
Loading

@G-Rath I'll rebase this after merging #255 - you might need to rebase your PRs as well. I'm happy to do it, I just don't wanna step on your toes if you're currently working on any of them 🙂

@G-Rath
Copy link
Collaborator
G-Rath commented Jul 20, 2019 •
edited
Loading

@SimenB you're welcome to rebase them - I suspect you're better at it anyway 😉

Right now I'm busy trying to figure out how to make a FunctionDeclaration AST node have a null body for coverage testing 😬

@SimenB
Copy link
Member Author
SimenB commented Jul 20, 2019

Cool, I'll rebase all of your open PRs, then 🙂 I'll ping you if tests fail in any of them and they're not trivial to fix

@SimenB SimenB force-pushed the reapply-ts branch 3 times, most recently from 3a2687e to 68c2d89 Compare July 21, 2019 13:06
SimenB and others added 20 commits July 22, 2019 02:11
@SimenB
chore: setup build and lint for TS migration
f08caeb
@SimenB
chore(lowercase-name): migrate to TS
0b0e28d
@SimenB
chore(no-jest-import): migrate to TS
04d2a15
@SimenB
chore(no-commented-out-tests): migrate to TS
1ce3e0e
@Mark1626 @SimenB
chore(valid-describe): migrate to TS (#308)
136a67c
@G-Rath @SimenB
chore(no-mocks-import): migrate to TS (#309)
bb54de6
@G-Rath @SimenB
chore(no-jasmine-globals): migrate to TS (#315)
2a0db83
@G-Rath @SimenB
chore(no-disabled-tests): migrate to TS (#315)
be7b806
@G-Rath @SimenB
chore(no-test-return-statement): migrate to TS (#320)
c6d33e1
@G-Rath @SimenB
chore(no-duplicate-hooks): migrate to TS (#318)
4c7e5c9
@G-Rath @SimenB
chore(prefer-inline-snapshots): migrate to TS (#319)
06c12a6
@G-Rath @SimenB
chore(no-focused-tests): migrate to TS (#314)
ca29df3
@G-Rath @SimenB
chore(no-hooks): migrate to TS (#322)
358cd09
@G-Rath @SimenB
chore(no-export): migrate to TS (#323)
c22043a
@G-Rath @SimenB
chore(no-if): migrate to TS (#324)
0d243e2
@G-Rath @SimenB
chore(prefer-spy-on): migrate to TS (#326)
637c3f4
@G-Rath @SimenB
chore(expect-expect): migrate to TS (#325)
4e187cd
@G-Rath @SimenB
chore(consistent-test-it): migrate to TS (#327)
83a0c39
@G-Rath @SimenB
chore(no-test-prefixes): migrate to TS (#328)
551204b
@G-Rath @SimenB
chore(prefer-strict-equal): migrate to TS (#329)
b772a41
@SimenB SimenB merged commit d0a8428 into master Jul 22, 2019
@SimenB
Copy link
Member Author
SimenB commented Jul 22, 2019

🎉 This PR is included in version 22.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimenB SimenB deleted the reapply-ts branch May 9, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimenB @G-Rath @Mark1626
0