Handle ssh:// URLs that doesn't contain git@ #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to specify and use github.com URLs as ssh://github.com/username/repo, as credentials used for SCM configuration usually include username. This change would allow to properly parse such URLs.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
LGTM, @lanwen ? |
|
After second look, it would be good to update also test: github-plugin/src/test/java/com/coravy/hudson/plugins/github/GitHubRepositoryNameTest.java. I'll update PR in few hours. |
|
Yes, text case required. |
|
Test case updated. |
lanwen
added a commit
that referenced
this pull request
Feb 19, 2016
Handle ssh:// URLs that doesn't contain git@
|
thanks! |
|
will be released as 1.17.1 soon |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to specify and use github.com URLs as
ssh://github.com/username/repo, as credentials usedfor SCM configuration usually include username.
This change would allow to properly parse such URLs.