8000 [FIXES JENKINS-32132] Check status message is null (in case of wrong … by lanwen · Pull Request #103 · jenkinsci/github-plugin · GitHub
[go: up one dir, main page]
Skip to content

[FIXES JENKINS-32132] Check status message is null (in case of wrong … #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2015
Merged

[FIXES JENKINS-32132] Check status message is null (in case of wrong … #103

merged 1 commit into from
Dec 20, 2015

Conversation

lanwen
Copy link
Member
@lanwen lanwen commented Dec 20, 2015

…deserialization)

Review on Reviewable

@lanwen
Copy link
Member Author
lanwen commented Dec 20, 2015

test will be in next pr

lanwen added a commit that referenced this pull request Dec 20, 2015
@lanwen
Merge pull request #103 from lanwen/fix_JENKINS-32132
2c193b4 
[FIXES JENKINS-32132] Check status message is null (in case of wrong …
@lanwen lanwen merged commit 2c193b4 into jenkinsci:master Dec 20, 2015
@lanwen lanwen deleted the fix_JENKINS-32132 branch December 20, 2015 22:09
@KostyaSha
Copy link
Member

If you are making this property ready for null, then mark it with @CheckForNull but i would prefer to see readResolve() and @Nonnull field or getter.

@KostyaSha
Copy link
Member

test will be in next pr

Sorry where is it?

@lanwen
Copy link
Member Author
lanwen commented Dec 21, 2015

this is a hotfix, so implementation may change after test will be ready (im working on gh mock)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanwen @KostyaSha
0