8000 maven: Fix changelog format by scurvydoggo · Pull Request #249 · jenkinsci/github-oauth-plugin · GitHub
[go: up one dir, main page]
Skip to content

maven: Fix changelog format #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

maven: Fix changelog format #249

merged 1 commit into from
Aug 1, 2023

Conversation

scurvydoggo
Copy link
Member
@scurvydoggo scurvydoggo commented Jul 31, 2023 •
edited
Loading

There was a typo in the maven config 🤦

The incrementals-tools tool uses -rc%d.%s as the default changelist format (instead of the desired %d.v%s as per the plugin guide). I think this is what caused the latest release build to fail, due to the tag starting with a -.

[INFO] Setting: -Dchangelist=-rc586.88708ce878fc -DscmTag=88708ce878fc051841ea8ab32749d51e0f89ea08
...
gh api -F tag=-rc586.88708ce878fc -F message=-rc586.88708ce878fc -F object=88708ce878fc051841ea8ab32749d51e0f89ea08 -F type=commit /repos/jenkinsci/github-oauth-plugin/git/tags
gh: Could not verify tag name (HTTP 422)

https://github.com/jenkinsci/github-oauth-plugin/actions/runs/5709233552

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@scurvydoggo scurvydoggo requested a review from a team as a code owner July 31, 2023 04:52
@scurvydoggo scurvydoggo merged commit f696a35 into master Aug 1, 2023
@scurvydoggo scurvydoggo deleted the fix-changelist branch August 1, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samrocketman samrocketman samrocketman approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scurvydoggo @samrocketman
0