8000 [JENKINS-75471] Gracefully skip repository if its processing fails in Organization scan by Dohbedoh · Pull Request #840 · jenkinsci/github-branch-source-plugin · GitHub
[go: up one dir, main page]
Skip to content

[JENKINS-75471] Gracefully skip repository if its processing fails in Organization scan #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2025
Merged

[JENKINS-75471] Gracefully skip repository if its processing fails in Organization scan #840

merged 3 commits into from
Mar 27, 2025

Conversation

Dohbedoh
Copy link
Contributor
@Dohbedoh Dohbedoh commented Mar 25, 2025 •
edited
Loading

Description

In case a single repository processing fails during the Organizsation scan, the entire scan would be interrupted. Propose to handle the exception to no report the error and not break the loop.
See JENKINS-75471 for further information.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@Dohbedoh Dohbedoh requested a review from a team as a code owner March 25, 2025 04:59
@Dohbedoh
Copy link
Contributor Author

First commit reproduce the error in unit test.
Second commit (coming soon) is the fix.

jglick
jglick reviewed Mar 27, 2025
View reviewed changes
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
&& repo.getSource() != null) {
witness.record(repo.getName(), false);
try {
if (repo.isArchived() && gitHubSCMNavigatorContext.isExcludeArchivedRepositories()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ignore WS)

@jglick jglick added the bug label Mar 27, 2025
@jglick jglick merged commit 9152b2f into jenkinsci:master Mar 27, 2025
17 checks passed
@jglick jglick mentioned this pull request Mar 27, 2025
Open
8 tasks
@Dohbedoh Dohbedoh deleted the JENKINS-75471 branch March 27, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dohbedoh @jglick
0