8000 [JENKINS-33623] Fix incorrect proxy handling by schulzh · Pull Request #48 · jenkinsci/github-branch-source-plugin · GitHub
[go: up one dir, main page]
Skip to content

[JENKINS-33623] Fix incorrect proxy handling #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[JENKINS-33623] Fix incorrect proxy handling #48

wants to merge 4 commits into from

Conversation

schulzh
Copy link
@schulzh schulzh commented Apr 19, 2016 •
edited by recena
Loading

JENKINS-33623

Basically the same bug as jenkinsci/github-plugin#109: The Jenkins ProxyConfiguration class expects only the hostname as a method parameter to createProxy, but the existing code gives it the whole URL.

@schulzh
Copy link
Author
schulzh commented Apr 28, 2016

@recena I hope you don't mind the mention to draw some attention to this PR (you seem to be quite active in this project)

@recena
Copy link
Contributor
recena commented May 3, 2016

@schulzh Let me take a look. Could you include a link to the Jira issue?

@schulzh
Copy link
Author
schulzh commented May 4, 2016 •
edited
Loading

@recena There is no Jira issue, at least AFAIK. I just had this problem on our server and found out what was wrong, so I fixed it.
EDIT: After searching in Jira, I indeed found a matching Issue: JENKINS-33623
This PR exactly solves this Issue.

@recena
Copy link
Contributor
recena commented May 4, 2016

@schulzh Please, assign the Jira issue yourself and change its status.

@schulzh
Copy link
Author
schulzh commented May 9, 2016

@recena Done.

@schulzh
Copy link
Author
schulzh commented May 12, 2016

@recena Could you merge this PR? I don't have the necessary authorization to do so.

@DamianLion
Copy link

+1

1 similar comment
@kenshi90
Copy link

+1

@ghost
Copy link
ghost commented May 17, 2016 •
edited by ghost
Loading

+1 👍

@SuperSpectre
Copy link

👍

@schulzh
Merge pull request #1 from jenkinsci/master
7a301a7 
Merge remote-tracking branch 'upstream/master'
@recena
Copy link
Contributor
recena commented May 17, 2016

@schulzh I hope to merge this PR today.

@schulzh
Copy link
Author
schulzh commented May 23, 2016

@recena Any updates on this?

@recena
Copy link
Contributor
recena commented May 23, 2016

@schulzh I'm sorry for delaying this.

2 similar comments
@recena
Copy link
Contributor
recena commented May 23, 2016

@schulzh I'm sorry for delaying this.

@recena
Copy link
Contributor
recena commented May 23, 2016

@schulzh I'm sorry for delaying this.

@DamianLion
Copy link

@recena Any updates on this?

@recena recena changed the title Fix incorrect proxy handling [JENKINS-33623] Fix incorrect proxy handling May 24, 2016
@recena recena mentioned this pull request May 24, 2016
Merged
3 tasks
@recena
Copy link
Contributor
recena commented May 25, 2016

I've prepared this PR #58

@recena
Copy link
Contributor
recena commented Jun 6, 2016

This PR supersedes this one.

@recena recena closed this Jun 6, 2016
dubrsl pushed a commit to dubrsl/github-branch-source-plugin that referenced this pull request Oct 17, 2020
@baymac
Impl GitLabAvatarTrait (jenkinsci#48)
03acddd 
* Impl GitLabAvatarTrait

* Add gitlab avatar trait to the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schulzh @recena @DamianLion @kenshi90 @SuperSpectre
0