Allow disabling of all network accesses #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ibbem, please revert the change to P.S. You need not rebase your branch. All commits will be squashed automatically at merge. |
parkr
approved these changes
Feb 24, 2025
|
From my side, this PR is ready to be (squash) merged. |
|
No @ibbem, this LGTM! @jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We use Nix to build our project reproducibly, including the github-pages documentation. This setup is also used in our CI to build the github-pages which are eventually deployed. Nix prohibits network connections (except if the output hash is specified, which is unpractical in this case) because the network is not reproducible. However, in some circumstances (e.g., the default installation on macOS) the Nix sandbox is disabled or weakened. Hence, github-metadata accesses the network which results in failing builds or differing outputs.
Feature Request
We would like to reliably disable network accesses without actually disabling the network.
Implemented solution
Network accesses are skipped if the environment variable
PAGES_DISABLE_NETWORKis set.Related issues