Fix test failures in JAX under NumPy 1.25.0rc1. #16297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We're going to hold off submitting this because numpy/numpy#23867 might resolve this. |
|
@hawkinsp numpy/numpy#23867 has been resolved via numpy/numpy#14847. The changes in this PR might be good anyway. |
Collaborator
|
@eendebakpt Thanks for the fix! Yes, it seems like this might be a tiny bit better anyway. I'll submit it. |
59245a8 to
34fb587
Compare
34fb587 to
ef3f2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test failures in JAX under NumPy 1.25.0rc1.
jnp.finfo(...)of an Array type yields:However,
np.finfo(...)no longer accepts NumPy arrays as input either, so it would be consistent to require the user to pass a dtype where they are currently passing an array.