10000 Fix for readCSV mismatch between Browser and Node by dcrescim · Pull Request #443 · javascriptdata/danfojs · GitHub
[go: up one dir, main page]
Skip to content

Fix for readCSV mismatch between Browser and Node #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix for readCSV mismatch between Browser and Node #443

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f59e5
feat: added skipEmptyLines: greedy to the papaparse default options t…
dcrescim Apr 19, 2022
f6afd8d
feat: added any because I couldn't get the typescript compiler to und…
dcrescim Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: added any because I couldn't get the typescript compiler to und… 
…erstand that skipEmptyLines is indeed an option
  • Loading branch information
@dcrescim
dcrescim committed Apr 19, 2022
commit f6afd8d39f07672865a3d36c63a70f84ab55b4a9
2 changes: 1 addition & 1 deletion src/danfojs-base/io/node/io.csv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const $readCSV = async (filePath: string, options?: CsvInputOptionsNode): Promis
}

const dataStream = request.get(filePath);
const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, optionsWithDefaults);
const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, optionsWithDefaults as any);
dataStream.pipe(parseStream);

const data: any = [];
Expand Down
0