Add failing tests for issue #412

javascriptdata · risenW · Mar 9, 2022 · Mar 8, 2022 · Mar 8, 2022 · Mar 8, 2022
commit 9b7a7f4fd35d9c86cc4cf05598d6cc6001342744
diff --git a/src/danfojs-browser/tests/core/generic.test.js b/src/danfojs-browser/tests/core/generic.test.js
@@ -407,14 +407,24 @@ describe("Generic (NDFrame)", function () {
   describe("Empty NDFrame", function () {
     it("Can successfully create an empty NDframe from empty array", function () {
       let data = [];
-      let sf = new dfd.NDframe({ data, isSeries: false });
+      let df = new dfd.NDframe({ data, isSeries: false });
+      assert.deepEqual(df.shape, [ 0, 0 ]);
+      assert.deepEqual(df.columns, []);
+      assert.deepEqual(df.dtypes, []);
+      assert.deepEqual(df.values, []);
+      let sf = new dfd.NDframe({ data, isSeries: true });
       assert.deepEqual(sf.shape, [ 0, 0 ]);
       assert.deepEqual(sf.columns, []);
       assert.deepEqual(sf.dtypes, []);
       assert.deepEqual(sf.values, []);
     });
     it("Can successfully create an empty NDframe from undefined data", function () {
       let data = undefined;
+      let df = new dfd.NDframe({ data, isSeries: false });
+      assert.deepEqual(df.shape, [ 0, 0 ]);
+      assert.deepEqual(df.columns, []);
+      assert.deepEqual(df.dtypes, []);
+      assert.deepEqual(df.values, []);
       let sf = new dfd.NDframe({ data, isSeries: true });
       assert.deepEqual(sf.shape, [ 0, 0 ]);
       assert.deepEqual(sf.columns, []);
@@ -423,12 +433,60 @@ describe("Generic (NDFrame)", function () {
     });
 
     it("Can successfully create an empty NDframe", function () {
+      let df = new dfd.NDframe({ isSeries: false });
+      assert.deepEqual(df.shape, [ 0, 0 ]);
+      assert.deepEqual(df.columns, []);
+      assert.deepEqual(df.dtypes, []);
+      assert.deepEqual(df.values, []);
       let sf = new dfd.NDframe({ isSeries: true });
       assert.deepEqual(sf.shape, [ 0, 0 ]);
       assert.deepEqual(sf.columns, []);
       assert.deepEqual(sf.dtypes, []);
       assert.deepEqual(sf.values, []);
     });
+
+    it("Can successfully create an empty NDframe with columns names", function () {
+      let data = [];
+      let df = new dfd.NDframe({ data, columns: [ "A", "B", "C" ], isSeries: false });
+      assert.deepEqual(df.shape, [ 0, 3 ]);
+      assert.deepEqual(df.columns, [ "A", "B", "C" ]);
+      assert.deepEqual(df.dtypes, []);
+      assert.deepEqual(df.values, []);
+      let sf = new dfd.NDframe({ data, columns: [ "A" ], isSeries: true });
+      assert.deepEqual(sf.shape, [ 0, 1 ]);
+      assert.deepEqual(sf.columns, [ "A" ]);
+      assert.deepEqual(sf.dtypes, []);
+      assert.deepEqual(sf.values, []);
+    });
+
+    it("Can successfully create an empty NDframe with columns names and dtypes", function () {
+      let data = [];
+      let df = new dfd.NDframe({ data, columns: [ "A", "B", "C" ], dtypes: [ "string", "string", "int32" ], isSeries: false });
+      assert.deepEqual(df.shape, [ 0, 3 ]);
+      assert.deepEqual(df.columns, [ "A", "B", "C" ]);
+      assert.deepEqual(df.dtypes, [ "string", "string", "int32" ]);
+      assert.deepEqual(df.values, []);
+      let sf = new dfd.NDframe({ data, columns: [ "A" ], dtypes: [ "string" ], isSeries: true });
+      assert.deepEqual(sf.shape, [ 0, 1 ]);
+      assert.deepEqual(sf.columns, [ "A" ]);
+      assert.deepEqual(sf.dtypes, [ "string" ]);
+      assert.deepEqual(sf.values, []);
+    });
+
+    it("Cannot successfully create an empty NDframe with only columns dtypes", function () {
+      let data = [];
+      assert.throws(
+        () => new dfd.NDframe({ data, dtypes: [ "string", "string", "int32" ], isSeries: false }),
+        Error,
+        "DtypeError: columns parameter must be provided when dtypes parameter is provided"
+      );
+      assert.throws(
+        () => new dfd.NDframe({ data, dtypes: [ "string" ], isSeries: true }),
+        Error,
+        "DtypeError: columns parameter must be provided when dtypes parameter is provided"
+      );
+    });
+
   });
 
 });
diff --git a/src/danfojs-browser/tests/core/indexing.test.js b/src/danfojs-browser/tests/core/indexing.test.js
@@ -408,6 +408,22 @@ describe("Iloc and Loc based Indexing", function () {
       assert.deepEqual(subDf.values, result);
 
     });
+
+    it("loc with no matches create a Empty DataFrame conserving columns information", function () {
+      const data = {
+        "Name": [ "Apples", "Mango", "Banana", "Pear" ],
+        "Count": [ 21, 5, 30, 10 ],
+        "Price": [ 200, 300, 40, 250 ]
+      };
+      const df = new dfd.DataFrame(data);
+      const subDf = df.loc({ rows: df["Count"].gt(50) });
+
+      assert.deepEqual(subDf.values, []);
+      assert.deepEqual(subDf.shape, [ 0, 3 ]);
+      assert.deepEqual(subDf.columns, [ "Name", "Count", "Price" ]);
+      assert.deepEqual(subDf.dtypes, [ "string", "int32", "int32" ]);
+
+    });
   });
 
 });
diff --git a/src/danfojs-node/test/core/generic.test.ts b/src/danfojs-node/test/core/generic.test.ts
@@ -344,14 +344,24 @@ describe("Generic (NDFrame)", function () {
     describe("Empty NDFrame", function () {
         it("Can successfully create an empty NDframe from empty array", function () {
             let data: any = [];
-            let sf = new NDframe({ data, isSeries: false });
+            let df = new NDframe({ data, isSeries: false });
+            assert.deepEqual(df.shape, [0, 0]);
+            assert.deepEqual(df.columns, []);
+            assert.deepEqual(df.dtypes, []);
+            assert.deepEqual(df.values, []);
+            let sf = new NDframe({ data, isSeries: true });
             assert.deepEqual(sf.shape, [0, 0]);
             assert.deepEqual(sf.columns, []);
             assert.deepEqual(sf.dtypes, []);
             assert.deepEqual(sf.values, []);
         });
         it("Can successfully create an empty NDframe from undefined data", function () {
             let data = undefined;
+            let df = new NDframe({ data, isSeries: false });
+            assert.deepEqual(df.shape, [0, 0]);
+            assert.deepEqual(df.columns, []);
+            assert.deepEqual(df.dtypes, []);
+            assert.deepEqual(df.values, []);
             let sf = new NDframe({ data, isSeries: true });
             assert.deepEqual(sf.shape, [0, 0]);
             assert.deepEqual(sf.columns, []);
@@ -360,11 +370,59 @@ describe("Generic (NDFrame)", function () {
         });
 
         it("Can successfully create an empty NDframe", function () {
+            let df = new NDframe({ data: [], isSeries: false });
+            assert.deepEqual(df.shape, [0, 0]);
+            assert.deepEqual(df.columns, []);
+            assert.deepEqual(df.dtypes, []);
+            assert.deepEqual(df.values, []);
             let sf = new NDframe({ data: [], isSeries: true });
             assert.deepEqual(sf.shape, [0, 0]);
             assert.deepEqual(sf.columns, []);
             assert.deepEqual(sf.dtypes, []);
             assert.deepEqual(sf.values, []);
         });
+
+        it("Can successfully create an empty NDframe with columns names", function () {
+            let data: any = [];
+            let df = new NDframe({ data, columns: [ "A", "B", "C" ], isSeries: false });
+            assert.deepEqual(df.shape, [ 0, 3 ]);
+            assert.deepEqual(df.columns, [ "A", "B", "C" ]);
+            assert.deepEqual(df.dtypes, []);
+            assert.deepEqual(df.values, []);
+            let sf = new NDframe({ data, columns: [ "A" ], isSeries: true });
+            assert.deepEqual(sf.shape, [ 0, 1 ]);
+            assert.deepEqual(sf.columns, [ "A" ]);
+            assert.deepEqual(sf.dtypes, []);
+            assert.deepEqual(sf.values, []);
+          });
+
+          it("Can successfully create an empty NDframe with columns names and dtypes", function () {
+            let data: any = [];
+            let df = new NDframe({ data, columns: [ "A", "B", "C" ], dtypes: [ "string", "string", "int32" ], isSeries: false });
+            assert.deepEqual(df.shape, [ 0, 3 ]);
+            assert.deepEqual(df.columns, [ "A", "B", "C" ]);
+            assert.deepEqual(df.dtypes, [ "string", "string", "int32" ]);
+            assert.deepEqual(df.values, []);
+            let sf = new NDframe({ data, columns: [ "A" ], dtypes: [ "string" ], isSeries: true });
+            assert.deepEqual(sf.shape, [ 0, 1 ]);
+            assert.deepEqual(sf.columns, [ "A" ]);
+            assert.deepEqual(sf.dtypes, [ "string" ]);
+            assert.deepEqual(sf.values, []);
+          });
+
+          it("Cannot successfully create an empty NDframe with only columns dtypes", function () {
+            let data: any = [];
+            assert.throws(
+                () => new NDframe({ data, dtypes: [ "string", "string", "int32" ], isSeries: false }),
+                Error,
+                "DtypeError: columns parameter must be provided when dtypes parameter is provided"
+            );
+            assert.throws(
+                () => new NDframe({ data, dtypes: [ "string" ], isSeries: true }),
+                Error,
+                "DtypeError: columns parameter must be provided when dtypes parameter is provided"
+            );
+          });
+
     });
 });
diff --git a/src/danfojs-node/test/core/indexing.test.ts b/src/danfojs-node/test/core/indexing.test.ts
@@ -411,6 +411,23 @@ describe("Iloc and Loc based Indexing", function () {
             assert.deepEqual(subDf.values, result);
 
         });
+
+        it("loc with no matches create a Empty DataFrame conserving columns information", function () {
+            const data = {
+              "Name": [ "Apples", "Mango", "Banana", "Pear" ],
+              "Count": [ 21, 5, 30, 10 ],
+              "Price": [ 200, 300, 40, 250 ]
+            };
+            const df = new DataFrame(data);
+            const subDf = df.loc({ rows: df["Count"].gt(50) });
+
+            assert.deepEqual(subDf.values, []);
+            assert.deepEqual(subDf.shape, [ 0, 3 ]);
+            assert.deepEqual(subDf.columns, [ "Name", "Count", "Price" ]);
+            assert.deepEqual(subDf.dtypes, [ "string", "int32", "int32" ]);
+
+          });
+
     })
 
 });