Fix bug #360: No Global variable renaming after 2 import declarations #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanex3339
reviewed
Jan 7, 2020
| @@ -142,7 +142,6 @@ export class ImportDeclarationTransformer extends AbstractNodeTransformer { | |||
| .replace(replaceableIdentifier.name, lexicalScopeNode); | |||
|
|
|||
| replaceableIdentifier.name = newReplaceableIdentifier.name; | |||
| NodeMetadata.set(replaceableIdentifier, { renamedIdentifier: true }); | |||
There was a problem hiding this comment.
I think it is better to wrap this line and the line above in the condition
if (replaceableIdentifier.name !== newReplaceableIdentifier.name) {
replaceableIdentifier.name = newReplaceableIdentifier.name;
NodeMetadata.set(replaceableIdentifier, { renamedIdentifier: true });
}
sanex3339
reviewed
Jan 8, 2020
| ...NO_ADDITIONAL_NODES_PRESET, | ||
| compact: true, | ||
| renameGlobals: true, | ||
| identifierNamesGenerator: 'mangled' |
There was a problem hiding this comment.
I think it is better to keep the default hexadecimal generator here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #360