8000 Fix issue 4846 by PiTheGuy · Pull Request #4855 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

Fix issue 4846 #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2025
Merged

Fix issue 4846 #4855

merged 3 commits into from
Sep 27, 2025

Conversation

PiTheGuy
Copy link
Contributor

Fixes #4846.

@codecov Codecov
Copy link
codecov bot commented Sep 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.354%. Comparing base (da40c26) to head (0129860).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...arsermodel/declarations/JavaParserTypeAdapter.java 50.000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4855       +/-   ##
===============================================
+ Coverage     58.351%   58.354%   +0.002%     
- Complexity      2531      2532        +1     
===============================================
  Files            671       671               
  Lines          38859     38861        +2     
  Branches        7063      7064        +1     
===============================================
+ Hits           22675     22677        +2     
+ Misses         13295     13293        -2     
- Partials        2889      2891        +2
Flag Coverage Δ
AlsoSlowTests 58.354% <50.000%> (+0.002%) ⬆️
javaparser-core 58.354% <50.000%> (+0.002%) ⬆️
javaparser-symbol-solver 58.354% <50.000%> (+0.002%) ⬆️
jdk-10 57.916% <50.000%> (+0.015%) ⬆️
8000 jdk-11 57.915% <50.000%> (+0.012%) ⬆️
jdk-12 57.915% <50.000%> (+0.009%) ⬆️
jdk-13 57.915% <50.000%> (+0.009%) ⬆️
jdk-14 58.154% <50.000%> (+0.002%) ⬆️
jdk-15 58.154% <50.000%> (+0.002%) ⬆️
jdk-16 58.129% <50.000%> (+0.002%) ⬆️
jdk-17 58.283% <50.000%> (+0.002%) ⬆️
jdk-18 58.283% <50.000%> (+0.002%) ⬆️
jdk-8 57.915% <50.000%> (+0.009%) ⬆️
jdk-9 57.911% <50.000%> (+0.007%) ⬆️
macos-latest 58.346% <50.000%> (+0.002%) ⬆️
ubuntu-latest 58.341% <50.000%> (+0.002%) ⬆️
windows-latest 58.336% <50.000%> (+0.002%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...arsermodel/declarations/JavaParserTypeAdapter.java 63.529% <50.000%> (+0.878%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af674c...0129860. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PiTheGuy PiTheGuy requested a review from jlerbsc September 27, 2025 18:21
@jlerbsc
Copy link
Collaborator
jlerbsc commented Sep 27, 2025

You still need to use spotless to format your changes (mvn sptoless:apply).

@jlerbsc jlerbsc merged commit 505d03c into javaparser:master Sep 27, 2025
34 of 35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Sep 27, 2025
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Sep 27, 2025
@jlerbsc
Copy link
Collaborator
jlerbsc commented Sep 27, 2025

Thank you for your contribution.

@PiTheGuy PiTheGuy deleted the fix-4846 branch September 28, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlerbsc jlerbsc Awaiting requested review from jlerbsc

Assignees

No one assigned

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Milestone

3.27.1

Development

Successfully merging this pull request may close these issues.

JavaParserTypeAdapter throw doesn't account for record declarations

2 participants

@PiTheGuy @jlerbsc
0