8000 XmlPrinter: fix duplicate attribute name in generated xml by sgqy · Pull Request #4806 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

XmlPrinter: fix duplicate attribute name in generated xml #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2025
Merged

XmlPrinter: fix duplicate attribute name in generated xml #4806

merged 4 commits into from
Aug 15, 2025

Conversation

sgqy
Copy link
Contributor
@sgqy sgqy commented Aug 6, 2025 •
edited
Loading

Patch of #4805

@sgqy sgqy mentioned this pull request Aug 6, 2025
Closed
@jlerbsc
Copy link
Collaborator
jlerbsc commented Aug 8, 2025

JP is not intended to provide an XML representation that is compatible with another library.

@jlerbsc jlerbsc closed this Aug 8, 2025
@jlerbsc jlerbsc reopened this Aug 12, 2025
@jlerbsc
Copy link
Collaborator
jlerbsc commented Aug 13, 2025

You must format the code with the command: mvn spotless:apply

@sgqy
Copy link
Contributor Author
sgqy commented Aug 14, 2025

@jlerbsc thanks. the command worked with modification.

@codecov Codecov
Copy link
codecov bot commented Aug 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.326%. Comparing base (12e4459) to head (582596a).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master     #4806   +/-   ##
===========================================
  Coverage     58.326%   58.326%           
  Complexity      2518      2518           
===========================================
  Files            671       671           
  Lines          38826     38826           
  Branches        7054      7054           
===========================================
  Hits           22646     22646           
  Misses         13295     13295           
  Partials        2885      2885
Flag Coverage Δ
AlsoSlowTests 58.326% <100.000%> (ø)
javaparser-core 58.326% <100.000%> (ø)
javaparser-symbol-solver 58.326% <100.000%> (ø)
jdk-10 57.876% <100.000%> (ø)
jdk-11 57.877% <100.000%> (ø)
jdk-12 57.877% <100.000%> (ø)
jdk-13 57.877% <100.000%> (ø)
jdk-14 58.124% <100.000%> (ø)
jdk-15 58.124% <100.000%> (ø)
jdk-16 58.096% <100.000%> (-0.003%) ⬇️
jdk-17 58.253% <100.000%> (ø)
jdk-18 58.253% <100.000%> (ø)
jdk-8 57.877% <100.000%> (-0.003%) ⬇️
jdk-9 57.876% <100.000%> (ø)
macos-latest 58.319% <100.000%> (ø)
ubuntu-latest 58.314% <100.000%> (ø)
windows-latest 58.308% <100.000%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...java/com/github/javaparser/printer/XmlPrinter.java 80.000% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7613d8...582596a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlerbsc jlerbsc merged commit ddb4a68 into javaparser:master Aug 15, 2025
35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Aug 15, 2025
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Aug 15, 2025
@jlerbsc
Copy link
Collaborator
jlerbsc commented Aug 15, 2025

Thank you for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlerbsc jlerbsc jlerbsc left review comments

Assignees

No one assigned

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Milestone

3.27.1

Development

Successfully merging this pull request may close these issues.

2 participants

@sgqy @jlerbsc
0