8000 Fix javadoc of Name class by bannmann · Pull Request #4789 · javaparser/javaparser · GitHub
[go: up one dir, main page]

Skip to content

Conversation

bannmann
Copy link
Contributor
@bannmann bannmann commented Jul 4, 2025

I could not find the mentioned name(...) method in this class. After a while, I found StaticJavaParser.parseName() and I guess that is the one that should be linked here.

Copy link
codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.326%. Comparing base (611e567) to head (0946eee).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master     #4789   +/-   ##
===========================================
  Coverage     58.326%   58.326%           
  Complexity      2514      2514           
===========================================
  Files            671       671           
  Lines          38782     38782           
  Branches        7041      7041           
===========================================
  Hits           22620     22620           
  Misses         13271     13271           
  Partials        2891      2891           
Flag Coverage Δ
AlsoSlowTests 58.326% <ø> (ø)
javaparser-core 58.326% <ø> (ø)
javaparser-symbol-solver 58.326% <ø> (ø)
jdk-10 57.877% <ø> (ø)
jdk-11 57.876% <ø> (ø)
jdk-12 57.876% <ø> (ø)
jdk-13 57.876% <ø> (ø)
jdk-14 58.123% <ø> (ø)
jdk-15 58.123% <ø> (ø)
jdk-16 58.098% <ø> (ø)
jdk-17 58.252% <ø> (ø)
jdk-18 58.252% <ø> (ø)
jdk-8 57.878% <ø> (ø)
jdk-9 57.874% <ø> (ø)
macos-latest 58.318% <ø> (ø)
ubuntu-latest 58.313% <ø> (ø)
windows-latest 58.307% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...main/java/com/github/javaparser/ast/expr/Name.java 61.538% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7158be7...0946eee. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlerbsc
Copy link
Collaborator
jlerbsc commented Jul 5, 2025

It seems to me that this refers to an old method that no longer exists, but I don't think it's necessary to introduce a reference to the StaticJavaParser class. I'd opt for the Name class constructor instead.

@bannmann
Copy link
Contributor Author
bannmann commented Jul 5, 2025

It seems to me that this refers to an old method that no longer exists, but I don't think it's necessary to introduce a reference to the StaticJavaParser class. I'd opt for the Name class constructor instead.

I was looking for a constructor that accepts one fully qualified name string and did not find one. So I was actually glad that the comment hinted at the existence of a helper method, even though I still had to find it.

So my suggestion is to either add that link or to move StaticJavaParser.parseName() to the Name class (and having the old method call the new one).

@jlerbsc jlerbsc merged commit fd967f3 into javaparser:master Jul 5, 2025
35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Jul 5, 2025
@bannmann bannmann deleted the name-javadoc branch July 5, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0