Fix IndexOutOfBoundsException resulting from empty varargs call as method usage #4754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4754 +/- ##
===============================================
+ Coverage 58.319% 58.321% +0.002%
- Complexity 2511 2512 +1
===============================================
Files 671 671
Lines 38778 38780 +2
Branches 7039 7040 +1
===============================================
+ Hits 22615 22617 +2
Misses 13271 13271
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jlerbsc
reviewed
May 15, 2025
| // type information about the parameters | ||
| if (actualParamTypes.isEmpty()) { | ||
| return methodUsage; | ||
| } else { |
There was a problem hiding this comment.
Is the else statement mandatory?
There was a problem hiding this comment.
It is not. I've updated the PR to remove it.
b59b768 to
ff3c527
Compare
|
Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash due to
java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 0when attempting to resolve a call to a method with only a single variadic parameter while providing no arguments, for example thefoocall in:This crash only occurs when attempting to resolve it via the
MethodUsagecode path, which is why thefoocall is used as an argument to theidcall. For the unit test, including all the code in the test code string didn't trigger this path either, so I added a test jar to be able to test this properly, along with the source and class file used to create the jar.The fix is to check whether the argument list is empty (and return if it is) before attempting to match/replace type parameters using the actual argument types.