Fix constructor resolution issue 4703 #4727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4727 +/- ##
===============================================
- Coverage 58.310% 58.303% -0.008%
Complexity 2512 2512
===============================================
Files 671 671
Lines 38756 38761 +5
Branches 7029 7031 +2
===============================================
Hits 22599 22599
- Misses 13265 13270 +5
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4703.
The
isMoreSpecificmethods inConstructorResolutionLogicandMethodResolutionLogicwere two methods that solve the same problem, butMethodResolutionLogic.isMoreSpecificis a lot more comprehensive. This PR fixes the linked issue and probably a number of other constructor resolution bugs by getting rid of the barebonesConstructorResolutionLogic.isMoreSpecificmethod and using the one inMethodResolutionLogicwhich now acceptsResolvedMethodLikeDeclarations. This should also simplify maintenance.I suspect it's possible to "merge" more of the functionality between
ConstructorResolutionLogicandMethodResolutionLogicinto aMethodLikeResolutionLogic, but there may be subtle differences to look out for and that's beyond the scope of this particular PR.