Fix range for cast expression with lambda child #4721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4721 +/- ##
===============================================
+ Coverage 58.235% 58.287% +0.052%
Complexity 2511 2511
===============================================
Files 671 671
Lines 38767 38768 +1
Branches 7034 7034
===============================================
+ Hits 22576 22597 +21
+ Misses 13295 13278 -17
+ Partials 2896 2893 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4488.
The cause of the issue is that lambda expressions are created in 2 steps (seemingly to avoid ambiguity issues). First, only a node for the lambda parameters is created (which could be a
NameExpror aLambdaExprwith only the params set) and then later in parsing the fullLambdaExpris created or the body is added to theLambdaExpr, depending on the context. The problem is that, for cast expressions, the range of the cast expression wasn't correctly adjusted.In the recursive
generateLambdacalls,propagateRangeGrowthOnRightis called to update the range of the lambda expression and all ancestor nodes, but this is called before the lambda expressioninneris added as a child to theCastExprnode, so the range of the cast was never updated. This PR fixes that by explicitly callingpropagateRangeGrowthOnRightafter the lambda is added to the cast.