Make JarTypeSolver and ReflectionTypeSolver a bit more versatile. #4716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles Java class paths support loading .class files either from .jar files, or from file hierarchies containing .class files. There's no reason why JarTypeSolver shouldn't be able to do that as well!
In particular, allow selecting the entire Java Class Library, and not just the absolute core JRE classes.
a8b7734 to
cbf34bd
Compare
jlerbsc
reviewed
Apr 8, 2025
| } | ||
|
|
||
| /** | ||
| * Given a apth to class file inside a class file hierarchy, extract the package name from the path. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4716 +/- ##
===========================================
Coverage 58.235% 58.235%
Complexity 2511 2511
===========================================
Files 671 671
Lines 38767 38767
Branches 7034 7034
===========================================
Hits 22576 22576
Misses 13295 13295
Partials 2896 2896
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jlerbsc
reviewed
Apr 8, 2025
| Path pathToJar = adaptPath("src/test/resources/javaparser-core-2.1.0.jar"); | ||
|
|
||
| // Unpack the jar file into a class hierarchy | ||
| Path tempDir = Files.createTempDirectory("jp"); |
There was a problem hiding this comment.
Will this directory be deleted?
There was a problem hiding this comment.
Switched to using @TempDir.
|
Thanks for this interesting PR. |
|
@jlerbsc I have addresed your review comments; would you like me to rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements to
TypeSolver:JarTypeSolvercan now also resolves types that live in.classfiles hierarchies (think the output fromjavac), without packaging them in a jar file first.ReflectionTypeSolvergets more flexible filtering; in particular, a pre-made filter is added for the entire Java Class Library.