Fix: issue 4697 Updating the com.google.guava:guava dependency to v334.5-jre fails. #4711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4711 +/- ##
===========================================
Coverage 58.200% 58.200%
Complexity 2499 2499
===========================================
Files 670 670
Lines 38721 38721
Branches 7023 7023
===========================================
Hits 22536 22536
Misses 13294 13294
Partials 2891 2891
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4697 .
Since version 33.4.0-jre the checker-framework library is no longer ported by the guava project. This causes compilation errors when using certain annotations. To correct the errors, it must be added as a dependency of the project. This is a temporary solution as the JP project is trying to free itself as much as possible from external dependencies.
As for the CheckForNull annotation, which doesn't belong to the checker-qual library, I've simply chosen to remove it from the code rather than add yet another dependency.