8000 Implement MethodResolutionCapability in JavassistRecordDeclaration by johanneskloos · Pull Request #4709 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

Implement MethodResolutionCapability in JavassistRecordDeclaration #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

Implement MethodResolutionCapability in JavassistRecordDeclaration #4709

merged 2 commits into from
Apr 3, 2025

Conversation

johanneskloos
Copy link
Contributor

Add an implementation of MethodResolutionCapability to JavassistRecordDeclaration, directly based on that from
JavasassistClassDeclaration. Comes with a unit test.

@codecov Codecov
Copy link
codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.200%. Comparing base (84441d0) to head (0d7c557).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4709       +/-   ##
===============================================
+ Coverage     58.194%   58.200%   +0.006%     
- Complexity      2497      2499        +2     
===============================================
  Files            670       670               
  Lines          38720     38721        +1     
  Branches        7023      7023               
===============================================
+ Hits           22533     22536        +3     
+ Misses         13295     13294        -1     
+ Partials        2892      2891        -1
Flag Coverage Δ
AlsoSlowTests 58.200% <100.000%> (+0.006%) ⬆️
javaparser-core 58.200% <100.000%> (+0.006%) ⬆️
javaparser-symbol-solver 58.200% <100.000%> (+0.006%) ⬆️
jdk-10 57.751% <0.000%> (-0.002%) ⬇️
jdk-11 57.751% <0.000%> (-0.002%) ⬇️
jdk-12 57.751% <0.000%> (-0.002%) ⬇️
jdk-13 57.751% <0.000%> (-0.002%) ⬇️
jdk-14 57.999% <100.000%> (+0.006%) ⬆️
jdk-15 57.999% <100.000%> (+0.006%) ⬆️
jdk-16 57.973% <100.000%> (+0.006%) ⬆️
jdk-17 58.128% <100.000%> (+0.006%) ⬆️
jdk-18 58.128% <100.000%> (+0.006%) ⬆️
jdk-8 57.752% <0.000%> (-0.002%) ⬇️
jdk-9 57.749% <0.000%> (-0.002%) ⬇️
macos-latest 58.193% <100.000%> (+0.006%) ⬆️
ubuntu-latest 58.188% <100.000%> (+0.006%) ⬆️
windows-latest 58.182% <100.000%> (+0.006%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ver/javassistmodel/JavassistRecordDeclaration.java 41.584% <100.000%> (+0.584%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae30bb4...0d7c557. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlerbsc
Copy link
Collaborator
jlerbsc commented Apr 3, 2025

That looks fine to me. Thank you for your contribution.

@jlerbsc jlerbsc merged commit 27a47f8 into javaparser:master Apr 3, 2025
35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Apr 3, 2025
@johanneskloos johanneskloos deleted the johanneskloos/add-method-resolution-capability-for-javassist-records branch April 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.27.0

Development

Successfully merging this pull request may close these issues.

2 participants

@johanneskloos @jlerbsc
0