Fix bug in VisitorSet.toString()
#4615
Conversation
VisitorSet.toString()
|
BTW, I think that the separator |
| return sb.replace(sb.length() - 2, sb.length(), "]").toString(); | ||
| return innerSet.stream() | ||
| .map(facade -> facade.overridden.toString()) | ||
| .collect(Collectors.joining(", ", "[", "]")); |
There was a problem hiding this comment.
I can't accept this PR, even though it undoubtedly improves the code, because you're changing the format of the character string returned by this method, which may have an impact on other users. Please only correct the issue you have identified.
There was a problem hiding this comment.
Sure, I have solved it and the format is the same as before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4615 +/- ##
=============================================
+ Coverage 58.055% 58.119% +0.063%
=============================================
Files 508 508
Lines 29780 29775 -5
Branches 5251 5251
=============================================
+ Hits 17289 17305 +16
+ Misses 10351 10332 -19
+ Partials 2140 2138 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Thank you for this contribution |
Thanks for your review. |
Hi, I haved closed previous PR and open a new one, and the case of no element, one element, and multiple elements is considered, and it's also supplemented with tests.