E535 Fix: issue 4579 Switch expr and var incompatibility by jlerbsc · Pull Request #4581 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

Fix: issue 4579 Switch expr and var incompatibility #4581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2024
Merged

Fix: issue 4579 Switch expr and var incompatibility #4581

merged 4 commits into from
Oct 10, 2024

Conversation

jlerbsc
Copy link
Collaborator
@jlerbsc jlerbsc commented Oct 10, 2024

Fixes #4579 .

@codecov Codecov
Copy link
codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.009%. Comparing base (e73d733) to head (4f1a0e8).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...anguage_level_validations/chunks/VarValidator.java 50.000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #4581       +/-   ##
=============================================
+ Coverage   57.999%   58.009%   +0.009%     
=============================================
  Files          508       508               
  Lines        29776     29778        +2     
  Branches      5253      5253               
=============================================
+ Hits         17270     17274        +4     
+ Misses       10374     10366        -8     
- Partials      2132      2138        +6
Flag Coverage Δ
AlsoSlowTests 58.009% <50.000%> (+0.009%) ⬆️
javaparser-core 58.009% <50.000%> (+0.009%) ⬆️
javaparser-symbol-solver 58.009% <50.000%> (+0.009%) ⬆️
jdk-10 57.975% <50.000%> (+0.022%) ⬆️
jdk-11 57.975% <50.000%> (+0.009%) ⬆️
jdk-12 57.975% <50.000%> (+0.022%) ⬆️
jdk-13 57.975% <50.000%> (+0.009%) ⬆️
jdk-14 57.975% <50.000%> (+0.022%) ⬆️
jdk-15 57.975% <50.000%> (+0.009%) ⬆️
jdk-16 57.975% <50.000%> (+0.009%) ⬆️
jdk-17 57.975% <50.000%> (+0.009%) ⬆️
jdk-18 57.975% <50.000%> (+0.009%) ⬆️
jdk-8 57.978% <50.000%> (+0.009%) ⬆️
jdk-9 57.972% <50.000%> (+0.019%) ⬆️
macos-latest 57.999% <50.000%> (+0.009%) ⬆️
ubuntu-latest 57.999% <50.000%> (+0.022%) ⬆️
windows-latest 57.985% <50.000%> (+0.009%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...anguage_level_validations/chunks/VarValidator.java 79.245% <50.000%> (-1.147%) ⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479ec4d...4f1a0e8. Read the comment docs.

@jlerbsc jlerbsc merged commit cc3c8ca into javaparser:master Oct 10, 2024
34 of 35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Oct 10, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Oct 10, 2024
@gpoussel gpoussel mentioned this pull request Nov 18, 2024
Closed
@emandirola emandirola mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Milestone
3.26.3
Development

Successfully merging this pull request may close these issues.

Switch expr and var incompatibility
1 participant
@jlerbsc
0