8000 Fixes #4526. Fix Node.PostOrderIterator for roots without children by ktul · Pull Request #4538 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

Fixes #4526. Fix Node.PostOrderIterator for roots without children #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fixes #4526. Fix Node.PostOrderIterator for roots without children #4538

merged 2 commits into from
Aug 21, 2024

Conversation

ktul
Copy link
Contributor
@ktul ktul commented Aug 20, 2024

Fixes #4526

@codecov Codecov
Copy link
codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.999%. Comparing base (0fcaf2e) to head (770f766).
Report is 29 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #4538       +/-   ##
=============================================
+ Coverage   57.859%   57.999%   +0.140%     
=============================================
  Files          508       508               
  Lines        29774     29776        +2     
  Branches      5253      5253               
=============================================
+ Hits         17227     17270       +43     
+ Misses       10416     10374       -42     
- Partials      2131      2132        +1
Flag Coverage Δ
AlsoSlowTests 57.999% <100.000%> (+0.140%) ⬆️
javaparser-core 57.999% <100.000%> (+0.140%) ⬆️
javaparser-symbol-solver 57.999% <100.000%> (+0.140%) ⬆️
jdk-10 57.952% <100.000%> (+0.140%) ⬆️
jdk-11 57.966% <100.000%> (+0.140%) ⬆️
jdk-12 57.952% <100.000%> (+0.140%) ⬆️
jdk-13 57.966% <100.000%> (+0.140%) ⬆️
jdk-14 57.952% <100.000%> (+0.140%) ⬆️
jdk-15 57.966% <100.000%> (+0.140%) ⬆️
jdk-16 57.966% <100.000%> (+0.140%) ⬆️
jdk-17 57.966% <100.000%> (+0.140%) ⬆️
jdk-18 57.966% <100.000%> (+0.140%) ⬆️
jdk-8 57.969% <100.000%> (+0.140%) ⬆️
jdk-9 57.952% <100.000%> (+0.140%) ⬆️
macos-latest 57.989% <100.000%> (+0.140%) ⬆️
ubuntu-latest 57.976% <100.000%> (+0.140%) ⬆️
windows-latest 57.976% <100.000%> (+0.140%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/main/java/com/github/javaparser/ast/Node.java 81.794% <100.000%> (+10.145%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0eb16b...770f766. Read the comment docs.

@jlerbsc
Copy link
Collaborator
jlerbsc commented Aug 20, 2024

You need to run the mvn spotless:apply task to normalise the format of your code.

@jlerbsc
Copy link
Collaborator
jlerbsc commented Aug 21, 2024

I don't know why spotless is generating an error now. It doesn't matter. Thank you for your contribution.

@jlerbsc jlerbsc merged commit 6529f26 into javaparser:master Aug 21, 2024
@jlerbsc jlerbsc added this to the next release milestone Aug 21, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Aug 21, 2024
@johannescoetzee johannescoetzee mentioned this pull request Aug 21, 2024
Merged
@ktul ktul deleted the Issue4526 branch August 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Milestone

3.26.2

Development

Successfully merging this pull request may close these issues.

Node.PostOrderIterator broken for root without children

2 participants

@ktul @jlerbsc
0