8000 Fix: 4330 Method 'forEach' cannot be resolved in certain context by jlerbsc · Pull Request #4436 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

Fix: 4330 Method 'forEach' cannot be resolved in certain context #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2024
Merged

Fix: 4330 Method 'forEach' cannot be resolved in certain context #4436

merged 2 commits into from
May 25, 2024

Conversation

jlerbsc
Copy link
Collaborator
@jlerbsc jlerbsc commented May 25, 2024

Fixes #4330 .

Type inference was implemented differently in the MethodCallExprContext and MethodResolutionLogic classes. To homogenise this code and avoid code redundancy, which is a source of errors, type inference is now implemented only in the MethodResolutionLogic class.

@codecov Codecov
Copy link
codecov bot commented May 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 51.922%. Comparing base (181fcd6) to head (388b3f2).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #4436       +/-   ##
=============================================
- Coverage   51.973%   51.922%   -0.052%     
=============================================
  Files          505       505               
  Lines        28453     28481       +28     
  Branches      4929      4939       +10     
=============================================
  Hits         14788     14788               
- Misses       11613     11641       +28     
  Partials      2052      2052
Flag Coverage Δ
AlsoSlowTests 51.922% <0.000%> (-0.052%) ⬇️
javaparser-core 51.922% <0.000%> (-0.052%) ⬇️
javaparser-symbol-solver 51.922% <0.000%> (-0.052%) ⬇️
jdk-10 51.918% <0.000%> (-0.052%) ⬇️
jdk-11 51.918% <0.000%> (-0.052%) ⬇️
jdk-12 51.918% <0.000%> (-0.052%) ⬇️
jdk-13 51.918% <0.000%> (-0.052%) ⬇️
jdk-14 51.918% <0.000%> (-0.052%) ⬇️
jdk-15 51.918% <0.000%> (-0.052%) ⬇️
jdk-16 51.918% <0.000%> (-0.052%) ⬇️
jdk-17 51.918% <0.000%> (-0.052%) ⬇️
jdk-18 51.918% <0.000%> (-0.052%) ⬇️
jdk-8 51.917% <0.000%> (-0.052%) ⬇️
jdk-9 51.918% <0.000%> (-0.052%) ⬇️
macos-latest 51.915% <0.000%> (-0.048%) ⬇️
ubuntu-latest 51.915% <0.000%> (-0.052%) ⬇️
windows-latest 51.901% <0.000%> (-0.052%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...parser/resolution/logic/MethodResolutionLogic.java 0.000% <0.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cac33b...388b3f2. Read the comment docs.

@jlerbsc jlerbsc merged commit d7ac502 into javaparser:master May 25, 2024
@jlerbsc jlerbsc added this to the next release milestone May 25, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Milestone

3.26.0

Development

Successfully merging this pull request may close these issues.

Method 'forEach' cannot be resolved in certain context

1 participant

@jlerbsc
0