E53F Fix: 'permits' and 'sealed' Contextual keyworlds usage by jlerbsc · Pull Request #4434 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

Fix: 'permits' and 'sealed' Contextual keyworlds usage #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2024
Merged

Fix: 'permits' and 'sealed' Contextual keyworlds usage #4434

merged 1 commit into from
May 25, 2024

Conversation

jlerbsc
Copy link
Collaborator
@jlerbsc jlerbsc commented May 25, 2024

Fixes #4041

From java 17, the keywords 'permits' and 'sealed' cannot be used as type identifiers in the context of a NormalClassDeclaration or NormalInterfaceDeclaration.

@codecov Codecov
Copy link
codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.973%. Comparing base (4fb1298) to head (181fcd6).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4434   +/-   ##
=========================================
  Coverage   51.973%   51.973%           
=========================================
  Files          505       505           
  Lines        28453     28453           
  Branches      4929      4929           
=========================================
  Hits         14788     14788           
  Misses       11613     11613           
  Partials      2052      2052
Flag Coverage Δ
AlsoSlowTests 51.973% <100.000%> (ø)
javaparser-core 51.973% <100.000%> (ø)
javaparser-symbol-solver 51.973% <100.000%> (ø)
jdk-10 51.969% <100.000%> (ø)
jdk-11 51.969% <100.000%> (ø)
jdk-12 51.969% <100.000%> (ø)
jdk-13 51.969% <100.000%> (ø)
jdk-14 51.969% <100.000%> (ø)
jdk-15 51.969% <100.000%> (ø)
jdk-16 51.969% <100.000%> (ø)
jdk-17 51.969% <100.000%> (ø)
jdk-18 51.969% <100.000%> (ø)
jdk-8 51.968% <100.000%> (ø)
jdk-9 51.969% <100.000%> (ø)
macos-latest 51.962% <100.000%> (ø)
ubuntu-latest 51.966% <100.000%> (ø)
windows-latest 51.952% <100.000%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...or/language_level_validations/Java17Validator.java 100.000% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22c723...181fcd6. Read the comment docs.

@jlerbsc jlerbsc merged commit f219edb into javaparser:master May 25, 2024
@jlerbsc jlerbsc added this to the next release milestone May 25, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label May 25, 2024
@RTxin RTxin mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Milestone
3.26.0
Development

Successfully merging this pull request may close these issues.

Can "sealed", "permits" keyworlds still be used as variable names (or method names) in Java 17?
1 participant
@jlerbsc
0