8000 javaparser-symbol-solver-core:add bndtools, build OSGi-Bundle by stbischof · Pull Request #2824 · javaparser/javaparser · GitHub
[go: up one dir, main page]
Skip to content

javaparser-symbol-solver-core:add bndtools, build OSGi-Bundle #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

javaparser-symbol-solver-core:add bndtools, build OSGi-Bundle #2824

wants to merge 1 commit into from

Conversation

stbischof
Copy link
@stbischof stbischof commented Oct 9, 2020 •
edited
Loading

OSGi Todos:
If you look in the manifest there are several Import Pageges that might be optional.

@stbischof stbischof mentioned this pull request Oct 9, 2020
Open
@stbischof
add bndtools, build OSGi-Bundle
198e10e 
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
@stbischof stbischof mentioned this pull request Nov 6, 2020
Closed
@MysterAitch MysterAitch added this to the next release milestone Nov 12, 2020
@MysterAitch
Copy link
Member

@stbischof -- could you rebase your PR please? It's saying there's a conflict, and the github UI isn't showing the "update" button for me to resolve this.

It's the weekend so I understand if you're not monitoring github and might not see this, but if you do manage to get it done in the next hour or two it'll make it into today's release 👍 :)

@MysterAitch
Copy link
Member

I've just tried replicating this PR but I can't seem to get it to trigger / do anything.

Changing the pom per this PR and running compile/package/verify doesn't trigger the creation of bnd.bnd. Manually running bnd:bnd-process doesn't seem to do it either.

Could you provide some more notes on how this might be run please?

I would hate to merge this manually produced bnd.bnd file, if it is never to be updated in the future.

@MysterAitch MysterAitch removed this from the next release milestone Nov 15, 2020
@MysterAitch
Copy link
Member

@stbischof - Please see the comments above.

@jlerbsc
Copy link
Collaborator
jlerbsc commented Nov 29, 2020

It seems that bnd-process goal generates files from bnd.bnd directives but does not generate bnd.bnd.
https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin
In core target directory there is a MANIFEST.MF i not sure if it is produced by bnd-process but since the manifest file is not declared in the project resources I think it is actually generated.

@stbischof
Copy link
Author

I changed 2 Plugins here.
bnd to generate osgi related files. Adds this to the bundle and the target folder.
The other is the change in maven-jar-plugin. To pick the Manifest.
Without thi instruction maven-jar-plugin would use its own Manifest

@MysterAitch MysterAitch mentioned this pull request Nov 29, 2020
Open
@MysterAitch
Copy link
Member

I might be being really thick here, but I can't find a way to reproduce or test this PR. This is likely due to my lack of understanding around OSGi and the bnd.bnd file itself!

  • How was the bnd.bnd file in this PR created? Manually? via running the maven plugin?
  • How is it used?

When I run mvn clean.. then mvn bnd:bnd-process or mvn package.. with and without a bnd.bnd file. In all combinations it seems that the MANIFEST.MF files created at target/classes/META-INF/MANIFEST.MF are always the same (just a timestamp difference) and this seems to be true even when manually extracting/inspecting the jar file too.

Is my understanding completely wrong and the bnd.bnd file is not generated? Instead the bnd.bnd file used as an input in generating the manifest file, perhaps?

My main worry is that if this file is manually created, it won't be kept up to date -- and I really would like to get this done correctly 👍

@MysterAitch
Copy link
Member
MysterAitch commented Nov 29, 2020 •
edited
Loading

@stbischof -- could you rebase your PR please? It's saying there's a conflict, and the github UI isn't showing the "update" button for me to resolve this.

@stbischof -- this still applies.. Even if I wanted to merge this PR I cannot due to the conflict. Please rebase or otherwise update your PR.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stbischof @MysterAitch @jlerbsc
0