8000 [http] Add config option for response buffer size with a new default by Playacem · Pull Request #2369 · javalin/javalin · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http] Add config option for response buffer size with a new default #2369

Merged
merged 2 commits into from
Mar 2, 2025
Merged

[http] Add config option for response buffer size with a new default #2369

merged 2 commits into from
Mar 2, 2025

Conversation

Playacem
Copy link
Member
@Playacem Playacem commented Feb 9, 2025

As discussed on Discord:
This PR adds a config option for the response buffer size that used to be the Kotlin default of 8kb and was set explicitly to 4096.
The new default is the same what Jetty has by default.

Link to the small discussion on Discord: https://discord.com/channels/804862058528505896/805106384977920040/1336426384981102663

@Playacem
[http] Add config option for response buffer size with a new default
6cc5948 
The new default is the same what Jetty has by default.
@codecov Codecov
Copy link
codecov bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.13%. Comparing base (2b63b76) to head (133c8be).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2369   +/-   ##
=========================================
  Coverage     87.12%   87.13%           
- Complexity     1320     1322    +2     
=========================================
  Files           148      148           
  Lines          4467     4469    +2     
  Branches        512      513    +1     
=========================================
+ Hits           3892     3894    +2     
  Misses          354      354           
  Partials        221      221

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Petersoj Petersoj mentioned this pull request Feb 17, 2025
Open
@tipsy
Copy link
Member
tipsy commented Mar 2, 2025

Thanks @Playacem, and thanks @dzikoysk for reviewing !

@tipsy tipsy merged commit a6fb01f into javalin:master Mar 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzikoysk dzikoysk dzikoysk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Playacem @tipsy @dzikoysk
0