8000 Handle invalid http verbs in micrometer plugin by byarr · Pull Request #2365 · javalin/javalin · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid http verbs in micrometer plugin #2365

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Handle invalid http verbs in micrometer plugin #2365

merged 1 commit into from
Mar 2, 2025

Conversation

byarr
Copy link
Contributor
@byarr byarr commented Jan 28, 2025 •
edited
Loading

When requests come in with invalid methods (e.g. POSTS instead of POST) the exisitng plugin fails to find the method and throws an exception (meaning no metrics are emitted).

Change to use the existng findByName method so that metrics are emitted.

Created an issue #2366 to track this.

@byarr byarr changed the title Use HandlerType.findByName so that we handle invalid names Handle invalid http verbs in micrometer plugin Jan 28, 2025
@tipsy
Copy link
Member
tipsy commented Mar 2, 2025

Makes sense @byarr, thank you !

@tipsy tipsy merged commit 4f5f594 into javalin:master Mar 2, 2025
@tipsy tipsy mentioned this pull request Mar 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byarr @tipsy
0