8000 [core] Fix `Cookie` `maxAge` docs by Petersoj · Pull Request #2357 · javalin/javalin · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix Cookie maxAge docs #2357

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

Petersoj
Copy link
Contributor

The existing docs are incorrect regarding negative numbers for Cookie maxAge. This PR copies the docs from here to fix it.

@tipsy tipsy merged commit 8b1dc1a into javalin:master Jan 18, 2025
12 checks passed
@tipsy
Copy link
Member
tipsy commented Jan 18, 2025

Thanks @Petersoj !

Copy link
codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (5de1d25) to head (a3636e5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2357   +/-   ##
=========================================
  Coverage     87.09%   87.09%           
  Complexity     1314     1314           
=========================================
  Files           148      148           
  Lines          4457     4457           
  Branches        509      509           
=========================================
  Hits           3882     3882           
  Misses          354      354           
  Partials        221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0