[cors] Disallow anyHost + allowCredentials #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2321 +/- ##
=========================================
Coverage 86.30% 86.30%
- Complexity 1311 1314 +3
=========================================
Files 148 148
Lines 4044 4046 +2
Branches 508 509 +1
=========================================
+ Hits 3490 3492 +2
Misses 333 333
Partials 221 221 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While helping people with CORS this is one thing I have seen people use and then getting confused as to why it doesn't work. This is already documented in the cors plugin page but catching this on startup should be a better experience.
This is technically a breaking change but as browsers already reject this combination should be considered a bug fix as we adopt the browser behaviour, leading to a better experience as you now get immediate feedback on what went wrong instead of having to debug this in a browser.