8000 Use `removeFirstOrNull` instead of `removeFirstKt` for null safety by Jerbell · Pull Request #2309 · javalin/javalin · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use removeFirstOrNull instead of removeFirstKt for null safety #2309

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Use removeFirstOrNull instead of removeFirstKt for null safety #2309

merged 6 commits into from
Aug 23, 2024

Conversation

Jerbell
Copy link
Contributor
@Jerbell Jerbell commented Aug 23, 2024 •
edited
Loading

#2309

This is very minor & shouldn't happen in reality. Only if the addCookie method for the servlet container does not set the Set-Cookie header. It could happen with a poor implementation or stub.

@codecov Codecov
Copy link
codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (e0b8de3) to head (fbcb1c3).
Report is 1 commits behind head on master.

Files Patch % Lines
javalin/src/main/java/io/javalin/http/Cookie.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2309   +/-   ##
=========================================
  Coverage     86.30%   86.30%           
  Complexity     1311     1311           
=========================================
  Files           148      148           
  Lines          4044     4044           
  Branches        508      508           
=========================================
  Hits           3490     3490           
  Misses          333      333           
  Partials        221      221

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tipsy tipsy merged commit 0d116cf into javalin:master Aug 23, 2024
15 checks passed
@tipsy
Copy link
Member
tipsy commented Aug 23, 2024

Thanks @Jerbell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jerbell @tipsy @dzikoysk
0