Add config to enforce content types strictly #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is valuable for being able to unconditionally use formParams in an application without risking consuming the body stream on requests where the client did not send form params.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2255 +/- ##
============================================
- Coverage 86.42% 86.32% -0.10%
- Complexity 1299 1309 +10
============================================
Files 148 148
Lines 4029 4038 +9
Branches 504 508 +4
============================================
+ Hits 3482 3486 +4
- Misses 331 333 +2
- Partials 216 219 +3 ☔ View full report in Codecov by Sentry. |
norrs
reviewed
May 30, 2024
| /** Returns true if request is application/x-www-form-urlencoded. */ | ||
| fun isFormUrlencoded(): Boolean = header(Header.CONTENT_TYPE)?.lowercase(Locale.ROOT)?.contains("application/x-www-form-urlencoded") == true | ||
|
|
||
| /** Returns true if request is application/x-www-form-urlencoded. */ |
There was a problem hiding this comment.
Suggested change
| /** Returns true if request is application/x-www-form-urlencoded. */ | |
| /** Returns true if request is application/json. */ |
I do however wonder if you should use startsWith for each value in the collection as usually content types can have definitions of character encoding etc in it, but it however should start with application/json. ie application/json; charset=iso-8859-1
This is correct per specification https://www.rfc-editor.org/rfc/rfc9110#media.type
|
Thanks @maths22, sorry about the long wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is valuable for being able to unconditionally use formParams
in an application without risking consuming the body stream on
requests where the client did not send form params.
For bodyAsClass/bodyStreamAsClass, this will throw a BadRequestResponse when trying to convert a non-JSON body to a class. For formParams and friends, the formParam list will be empty when trying to read form params from a request with a non-form-param content type.