8000 Handle invalid urlencoding in bodies by maths22 · Pull Request #2245 · javalin/javalin · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid urlencoding in bodies #2245

Merged
merged 1 commit into from
May 14, 2024
Merged

Handle invalid urlencoding in bodies #2245

merged 1 commit into from
May 14, 2024

Conversation

maths22
Copy link
Contributor
@maths22 maths22 commented May 14, 2024 •
edited
Loading

Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests gracefully

@codecov Codecov
Copy link
codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.39%. Comparing base (b983d51) to head (209e358).
Report is 57 commits behind head on master.

❗ Current head 209e358 differs from pull request most recent head 1a8a9c0. Consider uploading reports for the commit 1a8a9c0 to get more accurate results

Files Patch % Lines
javalin/src/main/java/io/javalin/http/Context.kt 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2245      +/-   ##
============================================
+ Coverage     86.31%   86.39%   +0.07%     
- Complexity     1297     1302       +5     
============================================
  Files           148      148              
  Lines          4042     4028      -14     
  Branches        506      504       -2     
============================================
- Hits           3489     3480       -9     
+ Misses          334      331       -3     
+ Partials        219      217       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maths22
Handle invalid urlencoding in bodies
1a8a9c0 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests gracefully
@maths22 maths22 force-pushed the careful-form-params branch from 209e358 to 1a8a9c0 Compare May 14, 2024 16:36
@maths22 maths22 changed the title Only parse formparams if content-type is application/x-www-form-urlencoded Handle invalid urlencoding in bodies May 14, 2024
@tipsy tipsy merged commit 7af10ca into javalin:master May 14, 2024
13 checks passed
@tipsy
Copy link
Member
tipsy commented May 14, 2024

Thanks @maths22 !

norrs pushed a commit to norrs/javalin that referenced this pull request May 16, 2024
@maths22 @norrs
[context] Handle invalid url encoding for form params (javalin#2245)
095e459 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests gracefully
@norrs norrs mentioned this pull request May 16, 2024
Merged
norrs added a commit to norrs/javalin that referenced this pull request May 16, 2024
@norrs
Handle invalid urlencoding in bodies
cb44479 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests
gracefully.

"backport" of javalin#2245 for javalin
4x.
norrs added a commit to norrs/javalin that referenced this pull request May 16, 2024
@norrs
Handle invalid urlencoding in bodies
c5740f0 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests
gracefully.

"backport" of javalin#2245 for javalin
4x.
norrs pushed a commit to norrs/javalin that referenced this pull request May 16, 2024
@maths22 @norrs
[context] Handle invalid url encoding for form params (javalin#2245)
534fa45 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests gracefully

Signed-off-by: Roy Sindre Norangshol <roy.sindre@norangshol.no>
@norrs norrs mentioned this pull request May 16, 2024
Merged
norrs added a commit to norrs/javalin that referenced this pull request May 16, 2024
@norrs
Handle invalid urlencoding in bodies
3476961 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests
gracefully.

"backport" of javalin#2245 for javalin
3x.

Signed-off-by: Roy Sindre Norangshol <roy.sindre@norangshol.no>
@norrs norrs mentioned this pull request May 16, 2024
Closed
tipsy pushed a commit that referenced this pull request May 16, 2024
@norrs @maths22
[context] Handle invalid url encoding for form params (#2245) (#2249)
2b8dfdb 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests gracefully

Signed-off-by: Roy Sindre Norangshol <roy.sindre@norangshol.no>
Co-authored-by: Jacob Burroughs <jburroughs@instructure.com>
tipsy pushed a commit that referenced this pull request May 16, 2024
@norrs
Handle invalid urlencoding in bodies (#2250)
1c32f73 
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests
gracefully.

"backport" of #2245 for javalin
4x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maths22 @tipsy
0