8000 Comparing 8fcff1b...3637139 · java-to-kotlin/code · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: java-to-kotlin/code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8fcff1b
Choose a base ref
...
head repository: java-to-kotlin/code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3637139
Choose a head ref
  • 14 commits
  • 27 files changed
  • 3 contributors

Commits on Jun 23, 2021

  1. Minimum git setup

    @dmcg
    Duncan McGregor authored and dmcg committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    0afc9da View commit details
    Browse the repository at this point in the history

  2. projects.0 : Gradle Java build

    @npryce @dmcg
    npryce authored and dmcg committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a64ebc9 View commit details
    Browse the repository at this point in the history

  3. projects.1 : add Kotlin plugin to the build 

    Kotlin version specified in property that can be overridden on command-line
    @npryce @dmcg
    npryce authored and dmcg committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    66ff11f View commit details
    Browse the repository at this point in the history

  4. IDE config for Kotlin formatting

    @npryce @dmcg
    npryce authored and dmcg committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    144bad9 View commit details
    Browse the repository at this point in the history

  5. BASELINE for all examples

    @dmcg
    dmcg committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1d281b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. open-to-sealed.0 : baseline for new open to sealed classes refactoring

    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    80313cd View commit details
    Browse the repository at this point in the history

  2. open-to-sealed.1 : move classes to same source file

    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6055e1b View commit details
    Browse the repository at this point in the history

  3. open-to-sealed.2 : make ItineraryItem a sealed class

    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    c52bee3 View commit details
    Browse the repository at this point in the history

  4. open-to-sealed.3 : add ItineraryItem.toCalendarEvent()

    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    09a5301 View commit details
    Browse the repository at this point in the history

  5. open-to-sealed.4 : extract mapOverlay as an extension (does not compile)

    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    bf772ed View commit details
    Browse the repository at this point in the history

  6. open-to-sealed.5 : get compiling again 

     - remove the now incorrect override modifiers
 - implement ItineraryItem.mapOverlay as an
   exhaustive with expr that calls the mapOverlay
   method of subclasses. Highlighted as smart-casts.
    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    c6e7346 View commit details
    Browse the repository at this point in the history

  7. open-to-sealed.6 : convert individual mapOverlay properties to extens… 

    …ions
    @dmcg
    dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6eae26a View commit details
    Browse the repository at this point in the history

  8. open-to-sealed.7 : move mapOverlay extension to geo package

    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    c043831 View commit details
    Browse the repository at this point in the history

  9. open-to-sealed.8 : move remaining non-fundamental methods to extensio… 

    …ns in suitable modules
    @npryce @dmcg
    npryce authored and dmcg committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3637139 View commit details
    Browse the repository at this point in the history
Loading
0