End to end tests for Tomcat operator #13
Conversation
…e starting download process
Merge kanendafromparis's new pipeline to deploy the operator to k8s for integration tets
|
Hold the reviews, looks like the test is failing. |
|
Ready for review |
| - uses: actions/cache@v2 | ||
| distribution: adopt-hotspot | ||
|
|
||
| - name: cache |
There was a problem hiding this comment.
This isn't needed anymore with setup-java v2. See operator-framework/java-operator-sdk#527 for details. Then again, maybe you need more control on the caching that what's provided by default?
| ${{ runner.os }}-maven- | ||
| ${{ runner.os }}-maven-m2 | ||
|
|
||
| - name: Set up Maven |
There was a problem hiding this comment.
Isn't maven set up as part of setup-java already?
| - name: Create Kubernetes KinD Cluster | ||
| uses: container-tools/kind-action@v1.5.0 | ||
| with: | ||
| cluster_name: tomcat-integration-test |
There was a problem hiding this comment.
Shouldn't this use ${KIND_CL_NAME} instead?
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.javaoperatorsdk</groupId> | ||
| <artifactId>operator-framework</artifactId> | ||
| <version>1.8.4</version> | ||
| <version>1.9.2</version> |
|
|
||
| @Test | ||
| public void test() { | ||
| Config config = new ConfigBuilder().withNamespace(null).build(); |
There was a problem hiding this comment.
You could probably use: Config.autoConfigure(null) instead here.
|
Thanks @metacosm I'll fix these with another PR. |
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.notNullValue; | ||
|
|
||
| public class IntegrationTest { |
There was a problem hiding this comment.
Could we brake this method into smaller chuns based on semantics, it's kinda hard to follow this way.
These tests are meant to be the blueprint for future end-to-end tests. This PR also includes significant fixes to the TomcatOperator to fix issues revealed by the tests.
The important characteristics of this test are: