8000 SSLMode support for MysqlConnectionFactoryProvider by tkurylek · Pull Request #349 · jasync-sql/jasync-sql · GitHub
[go: up one dir, main page]
Skip to content

SSLMode support for MysqlConnectionFactoryProvider #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

SSLMode support for MysqlConnectionFactoryProvider #349

merged 1 commit into from
Jan 12, 2023

Conversation

tkurylek
Copy link
@tkurylek tkurylek commented Jan 2, 2023

This PR fixes #337

@tkurylek tkurylek force-pushed the feature/r2dbc-mysql-ssl-mode-support branch from f820caa to 6542087 Compare January 2, 2023 12:46
@tkurylek
Copy link
Author
tkurylek commented Jan 9, 2023

@oshai The MysqlSSLConfigurationFactoryTest passes locally on my machine (via ./gradlew clean build). Do you know why the PR fails here: https://github.com/jasync-sql/jasync-sql/actions/runs/3822628348/jobs/6507771842 ?

@oshai
Copy link
Contributor
oshai commented Jan 10, 2023

I will check locally once I get to it.

@oshai
Copy link
Contributor
oshai commented Jan 12, 2023

I just run it again and it passed. It looks something is flaky, hope will get to investigate it later.

@oshai oshai merged commit 613b46d into jasync-sql:master Jan 12, 2023
@oshai
Copy link
Contributor
oshai commented Jan 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL Mode support for MySQL
2 participants
@tkurylek @oshai
0